Joseph B. McQueen
a793c9f39b
Two features stitched together because they touch the same building-
job data path.
--- 1. Retract preview DM on cancel -----------------------------------
The /jobs/edit flow DMs a preview of the composed message to the
sender's own Webex space. Until now that DM lingered even if the
sender then hit Cancel or Discard.
- /jobs/edit now stores the returned message id as
jobs.building[key].previewMessageId.
- /jobs/cancel captures that id before deleting the building entry,
saves the cancel first, then fires a best-effort
DELETE /v1/messages/<id> against Webex.
- New deleteWebexMessage(messageId, appName) helper wraps the DELETE.
Uses the bot token (bots own their messages) and never throws — a
Webex hiccup logs but doesn't fail the cancel that already
succeeded on our side. Called fire-and-forget so the HTTP response
isn't blocked on a slow Webex round trip.
--- 2. Admin: manage authorized users -------------------------------
Admin authority lives in a new top-level config.admins array of
personIds (seeded with Joe's id). Admin actions are cross-bot in
concept but the routes are :app-scoped because the resource being
edited is per-bot and it lets admin reuse the existing OAuth session
without a separate auth surface.
Helpers
- lib/helpers.js: new pure isAdmin(config, personId) that fails
closed when admins is missing, not-an-array, or config is null.
- test/helpers.test.js: 5 new assertions covering the happy path,
the "not in list" case, missing personId, non-array admins, and
missing config. Total suite is now 48 assertions across 11 groups.
Server-side (index.js)
- New findPersonByEmail(email) helper hits Webex /v1/people?email=
using the service account token, returns
{ id, displayName, email, avatar } or null.
- /info now returns isAdmin so the client can decide whether to
render the admin dropdown.
- New requireAdmin(req, res) gate returns 401 for signed-out and
403 for signed-in-but-not-admin (distinct codes so the frontend
can render distinct panels).
- GET /CollabCentral/:app/admin/users → list users
- POST /CollabCentral/:app/admin/users → lookup + add
- DELETE /CollabCentral/:app/admin/users/:id → remove
- Shared adminUserRow / adminUsersList shape so every response is an
authoritative snapshot the client can render without merging.
- DELETE of an unknown id is idempotent — returns 200 removed:false
without rewriting config.json.
Frontend
- New html/admin.html + html/admin.js on the shared layout. Panels
swap between not-signed-in / not-admin / admin. Add-user form
takes an email; user list renders as rows with Webex avatar
(fallback initials), name, email, favorite-group count, and a
Remove button that confirm()s before firing DELETE.
- html/js/app.js: renderUserChip() replaces the plain-text top-right
user label with a proper button + dropdown menu when the caller
is an admin. Menu is keyboard-friendly (Escape to close), closes
on outside-click, and currently exposes one item ("Admin" →
admin.html). Non-admins get the plain-text label unchanged, so
the existing pages are visually identical for them.
- html/css/app.css: new .appHeader__userBtn / .appHeader__userMenu
dropdown, .inlineFieldRow for the email-plus-button pattern, and
.userRow* rules for the admin user list.
Config
- Add config.admins array seeded with Joe McQueen's personId.
- config.json also picks up an in-app state change from the running
instance (an "AV Team" favorite removed from Joe's techupdates
authorized entry via the favorites UI). Rolling that into this
commit so the file stops drifting from origin.
Co-authored-by: Cursor <cursoragent@cursor.com>
66 lines
2.7 KiB
HTML
66 lines
2.7 KiB
HTML
<!DOCTYPE html>
|
|
<html lang="en">
|
|
|
|
<head>
|
|
<meta charset="utf-8">
|
|
<meta name="viewport" content="width=device-width, initial-scale=1">
|
|
<title>CollabCentral</title>
|
|
<link id="appFavicon" rel="icon" type="image/x-icon" href="favicon.ico">
|
|
<link rel="stylesheet" href="css/app.css">
|
|
</head>
|
|
|
|
<body data-page="admin" data-title-suffix="Admin">
|
|
|
|
<header class="appHeader">
|
|
<div class="appHeader__inner">
|
|
<div class="appHeader__brand">
|
|
<div id="appAvatar" class="appHeader__avatar"></div>
|
|
<div id="appLabel" class="appHeader__label">Loading…</div>
|
|
</div>
|
|
<nav class="appHeader__nav">
|
|
<a href="./sendMessage.html" data-nav="send">Send Message</a>
|
|
<a href="./monitorJobs.html" data-nav="monitor">Monitor Jobs</a>
|
|
</nav>
|
|
<div class="appHeader__spacer"></div>
|
|
<div id="appUser" class="appHeader__user"></div>
|
|
</div>
|
|
</header>
|
|
|
|
<div id="unauthorizedPanel" class="panel hidden">
|
|
<h2>You don't have access to this bot</h2>
|
|
<p>Your account isn't on the authorized list for this bot. If you believe this is a mistake, contact the bot's administrator.</p>
|
|
</div>
|
|
|
|
<div id="notAdminPanel" class="panel hidden">
|
|
<h2>Admin only</h2>
|
|
<p>You're signed in, but this page is only available to CollabCentral administrators.</p>
|
|
</div>
|
|
|
|
<div id="adminPanel" class="container hidden">
|
|
<div class="card">
|
|
<h1 class="pageTitle">Authorized users</h1>
|
|
<p class="pageSubtitle">People who can compose and send messages as <span id="botLabelInline">this bot</span>. Add anyone by their Webex email; their name and avatar are pulled from Webex automatically.</p>
|
|
|
|
<form id="addUserForm" class="addUserForm">
|
|
<div class="field">
|
|
<label for="newUserEmail">Add a user by email</label>
|
|
<div class="inlineFieldRow">
|
|
<input type="email" id="newUserEmail" required autocomplete="off" placeholder="someone@example.com">
|
|
<button type="submit" class="btn btn-primary">Add user</button>
|
|
</div>
|
|
<span id="addUserStatus" class="fieldStatus" role="status" aria-live="polite"></span>
|
|
</div>
|
|
</form>
|
|
|
|
<div id="userListWrapper" class="userList">
|
|
<div id="userListEmpty" class="hint hidden">Nobody is authorized yet. Add someone above.</div>
|
|
<ul id="userList" class="userList__items"></ul>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<script src="js/app.js"></script>
|
|
<script src="admin.js"></script>
|
|
</body>
|
|
|
|
</html>
|